Hello Right...
Salt is a good additive to the tank water. I've used it for 10 years or so in my large, planted tanks, with what I believe are good results. Salt has a number of benefits especially for Livebearers, like Guppies, Swordtails, Platys and Mollies. It supplies healthful minerals, reduces the harmful effects of ammonia and nitrite produced from fish wastes, calms stressed fish by easing the breathing process and many if not all of the pathogens that can infect fish don't tolerate even traces of aquarium salt in the tank water.
I've kept a number of different fish and shrimp over the years and have used salt in all my tanks.
It's up to the water keeper. I think it helps.
B
Salt, as in NaCl, is only one mineral, so what other 'healthful' minerals is it supplying? And what about NaCl is healthful? The inhibition of nitrite toxicity via salt use is well known, but the use of salt is a band-aid to a temporary problem, since nitrites do not perpetually sit in a system. And how does salt reduce the harmful effects of ammonia?
How does salt make fish breathe easier? Is this an osmotic regulation thing? And if so, why not mention that the term 'salt' is being used in a very generic way here. Have a look at electrolytes and how 'salts' help. Basic table salt is on this list, but it's only one among other 'salts' that perform this function. Potassium, magnesium, and calcium are among them.
And the thing about pathogens being intolerable of salt is just outright wrong, unless there are no pathogens in brackish and saltwater systems? There are also many pathogens that need antibiotics or some other sort of heavy treatment apart from salt to deal with.
Not trying to be blunt, but this is exactly how these longtime myths and misinformation gets perpetuated. Euryhaline fish can sometimes benefit from a brackish environment (not the same as dumping aquarium salt in a tank), but in nearly all cases people do not stock their tanks based on different fishes ability to tolerate salt water. So why subject the fish to it when they don't need it?
Re: the OP - What you should be asking is WHY do the people that use salt, use it? Truth is, there's not much substance to it other than old wives tales or a misunderstanding of the basic science behind the concept.
Again, we are not talking about using salt as a medication, but rather as a water conditioner. They are two totally different subjects.